feat(filter): no longer infer scope in filters #8137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
approved these changes
May 14, 2024
chris-olszewski
deleted the
chrisolszewski/turbo-3125-stop-inference-of-package-names-in-scope
branch
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description Previously we would infer scope for name filters if there was exactly one matching package. e.g. `turbo build --filter=ui` would run `@a/ui#build` if there was a `@a/ui` package in the workspace This is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding `@b/ui` would cause *no* tasks to be run along with a zero exit code. ### Testing Instructions Updated unit test to verify inference no longer works and using the explicit package name still works.
|
Can this be put behind a flag or something? It's super annoying to have to type the namespace all day. This isn't an issue unless you add the same package name twice, which is a severe skill issue anyway. Why make things unnecessarily hard and annoying to type for the 99.9% of normal users? Can we at least get an option for a default namespace so we don't have to type it over and over all day if it matches the default NS? |
|
Referring to https://turbo.build/repo/docs/reference/run, I think there's a similar situation that happens to script names. For local development, writing the scope is indeed annoying, but for CI, I can see why writing the full package names is the right call. Would it be possible to force full package names on CI, and have the old behavior still work for local development? |
3 tasks
|
+1. This is a degradation in user experience. On conflict, the command should run on I started a discussion here: #8524 |
|
Answered some concerns here: #8524 (comment) |
|
Elaborated that your answer doesn't address my concerns here: #8524 (comment) |
denolfe
added a commit
to payloadcms/payload
that referenced
this pull request
Aug 28, 2024
Updating all turborepo npm scripts for this rather inconvenient breaking change: vercel/turborepo#8137
DerMolly
added a commit
to hedgedoc/hedgedoc
that referenced
this pull request
Aug 31, 2024
turbo now wants you to specify the whole name and not just part of the name. See: vercel/turborepo#8137 Signed-off-by: Philip Molares <[email protected]>
DerMolly
added a commit
to hedgedoc/hedgedoc
that referenced
this pull request
Aug 31, 2024
turbo now wants you to specify the whole name and not just part of the name. See: vercel/turborepo#8137 Signed-off-by: Philip Molares <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we would infer scope for name filters if there was exactly one matching package.
e.g.
turbo build --filter=uiwould run@a/ui#buildif there was a@a/uipackage in the workspaceThis is confusing and can result in accidentally breaking filters when a conflicting package is added e.g. adding
@b/uiwould cause no tasks to be run along with a zero exit code.Testing Instructions
Updated unit test to verify inference no longer works and using the explicit package name still works.