perf: Merge multiple EsmBinding
#8699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
reviewed
Jul 9, 2024
sokra
reviewed
Jul 10, 2024
sokra
reviewed
Jul 10, 2024
Comment on lines
273
to
274
| let bindings = EsmBindings::new(take(&mut self.bindings)); | ||
| self.add_code_gen(bindings); |
There was a problem hiding this comment.
Check for self.bindings.is_empty(), e. g. commonjs modules won't have bindings at all
sokra
approved these changes
Jul 10, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jul 12, 2024
# Turbopack * vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> ### What? Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 ### Why? To keep in sync ### How? - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Merge multiple `EsmBinding` into single `CodeGeneratable` ### Testing Instructions This is a pure optimization, so if the behavior is same it's all good. Closes PACK-3147
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Merge multiple `EsmBinding` into single `CodeGeneratable` ### Testing Instructions This is a pure optimization, so if the behavior is same it's all good. Closes PACK-3147
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Merge multiple `EsmBinding` into single `CodeGeneratable` ### Testing Instructions This is a pure optimization, so if the behavior is same it's all good. Closes PACK-3147
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Merge multiple `EsmBinding` into single `CodeGeneratable` ### Testing Instructions This is a pure optimization, so if the behavior is same it's all good. Closes PACK-3147
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge multiple
EsmBindinginto singleCodeGeneratableTesting Instructions
This is a pure optimization, so if the behavior is same it's all good.
Closes PACK-3147