Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: Enable tree shaking in next.js" #8752

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Revert "feat: Enable tree shaking in next.js" #8752

merged 1 commit into from
Jul 15, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 15, 2024 •
edited
Loading

Reverts #8523

We need to revert this due to some changes in turbopack code

@kdy1 kdy1 requested review from a team as code owners July 15, 2024 18:59
@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 7:01pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 7:01pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 7:01pm

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 19:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 merged commit 99119e2 into main Jul 15, 2024
52 of 53 checks passed
@kdy1 kdy1 deleted the revert-8523-kdy1/tree-shake branch July 15, 2024 19:07
kdy1 added a commit that referenced this pull request Jul 15, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
60c597b 
This reverts commit 99119e2.
kdy1 added a commit that referenced this pull request Jul 15, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
d110ed2 
This reverts commit 99119e2.
kdy1 added a commit that referenced this pull request Jul 18, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
7009c71 
This reverts commit 99119e2.
kdy1 added a commit that referenced this pull request Jul 19, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
6615c0c 
This reverts commit 99119e2.
kdy1 added a commit that referenced this pull request Jul 20, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
08d9ace 
This reverts commit 99119e2.
kdy1 added a commit that referenced this pull request Jul 25, 2024
@kdy1
Revert "Revert "feat: Enable tree shaking in next.js" (#8752)"
e9b06fa 
This reverts commit 99119e2.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8752)
9fe6600 
Reverts vercel/turborepo#8523

We need to revert this due to some changes in turbopack code
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8752)
cb698a0 
Reverts vercel/turborepo#8523

We need to revert this due to some changes in turbopack code
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8752)
4636af0 
Reverts vercel/turborepo#8523

We need to revert this due to some changes in turbopack code
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1
Revert "feat: Enable tree shaking in next.js" (vercel/turborepo#8752)
76cfaed 
Reverts vercel/turborepo#8523

We need to revert this due to some changes in turbopack code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @bgw