Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): validate package name on full graph #9102

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

chris-olszewski
Copy link
Member

Description

Fixes #9096

The issue was that the validation was run against an already filtered set of packages if another selector was provided i.e. --filter foo[commit] the name filter foo would run against only packages that were changed since commit. This meant that foo would be incorrectly reported as not existing.

This PR changes so the package existence check is run against all packages in the graph instead of an already filtered set.

Testing Instructions

Added red->green unit test

Verify that this PR correctly handles the repro provided in #9096

[1 olszewski@chriss-mbp] /tmp/turbo-filter-break $ turbo_dev --skip-infer run lint '--filter=...@repo/eslint-config[HEAD~1]' 
turbo 2.1.1

• Packages in scope: 
• Running lint in 0 packages
• Remote caching disabled

No tasks were executed as part of this run.

 Tasks:    0 successful, 0 total
Cached:    0 cached, 0 total
  Time:    75ms

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 3:47pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-gatsby-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-native-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-svelte-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-tailwind-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm
examples-vite-web ⬜️ Ignored (Inspect) Sep 3, 2024 3:47pm

@chris-olszewski chris-olszewski merged commit 48c56e6 into main Sep 5, 2024
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_gh_9096 branch September 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package not found when filtering with package and git specifier
2 participants