fix(filter): validate package name on full graph #9102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9096
The issue was that the validation was run against an already filtered set of packages if another selector was provided i.e.
--filter foo[commit]
the name filterfoo
would run against only packages that were changed sincecommit
. This meant thatfoo
would be incorrectly reported as not existing.This PR changes so the package existence check is run against all packages in the graph instead of an already filtered set.
Testing Instructions
Added red->green unit test
Verify that this PR correctly handles the repro provided in #9096