refactor(query): make immediate dependencies default #9114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Sep 6, 2024
crates/turborepo-lib/src/query.rs
Outdated
| @@ -335,7 +335,7 @@ impl Package { | |||
| } | |||
|
|
|||
| /// The downstream packages that directly depend on this package | |||
| async fn immediate_dependencies(&self) -> Result<Vec<Package>, Error> { | |||
| async fn dependencies(&self) -> Result<Vec<Package>, Error> { | |||
There was a problem hiding this comment.
Should this be direct_dependencies? Gives us the nice direct_dependencies U indirect_dependencies = dependencies relation
There was a problem hiding this comment.
Oh indirect_dependencies is all transitive dependencies so it's more direct_dependencies ⊆ indirect_dependencies. I'm down to rename it if that's clearer (cc @anthonyshew)
chris-olszewski
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a
dependenciesfield on ourPackagetype inturbo query. This returned all the transitive dependencies, i.e. the dependencies of the package's dependencies and their dependencies, and so on. This is a little confusing, so now we have explicitdirectDependencies,indirectDependenciesandallDependenciesfields.Testing Instructions
Tests in
command-query.tare updated.