perf(tui): only rerender if a non-tick event has been received #9121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Sep 6, 2024
unstubbable
added a commit
to vercel/next.js
that referenced
this pull request
Sep 16, 2024
This version of Turborepo reduces the CPU usage when running `pnpm dev` (via vercel/turborepo#9121).
unstubbable
added a commit
to vercel/next.js
that referenced
this pull request
Sep 16, 2024
This version of Turborepo reduces the CPU usage when running `pnpm dev` (via vercel/turborepo#9121).
unstubbable
added a commit
to vercel/next.js
that referenced
this pull request
Sep 16, 2024
This version of Turborepo reduces the CPU usage when running `pnpm dev` (via vercel/turborepo#9121).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ratatuidoes a great job of only updating cells that are different between render, but constructing thevt100screen can be intensive.This PR avoid constructing the screen if there are no updates to the the app state meaning there's no reason to re-render the TUI.
There are some additional changes we can also make to lower CPU usage more:
Screenis less resource intensive e.g. perf: avoid allocation on Cell::contents doy/vt100-rust#14Testing Instructions
Using TUI in next.js
Before
After
Ran via
cargo build -p turbo --releaseandturbo_dev --skip-infer dev -F next