feat(mfe): inject local proxy #9356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Oct 31, 2024
Comment on lines
+212
to
+213
| // TODO: leverage package manager to find the local proxy | ||
| let program = package_dir.join_components(&["node_modules", ".bin", "micro-frontends"]); |
NicholasLYang
approved these changes
Oct 31, 2024
| pub struct CommandFactory<'a> { | ||
| providers: Vec<Box<dyn CommandProvider + 'a + Send>>, |
There was a problem hiding this comment.
Are we going to have more providers than this? It's a little general for two implementations
There was a problem hiding this comment.
If we ever want to support additional tasks that don't come from package.json scripts (turbo.json, non-JS, etc) I expect this is where we would put those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds all support necessary for starting a MFE local proxy:
CommandProviderto allow for multiple strategies for constructing a command depending on the typemicro-frontends.jsoncmicro-frontends.jsoncfound in the package graph*proxytask if MFE configs are foundproxytasks in engine building step if a MFE dev task is found in the product of the package--filterand the tasks specified inturbo runCommandProviderthat construct a command that invokes the MFE local proxyFollow up work:
Testing Instructions
In a repository with MFE, run a dev task for one of the configured MFE. This should result in a
#proxytask being injected for that MFE and correctly configured to route traffic to the dev tasks or a remote host.