Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hints by lint:scss and stylelint #415

Merged
merged 1 commit into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# EditorConfig is awesome: https://EditorConfig.org

# top-most EditorConfig file
root = true

[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
8 changes: 7 additions & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,18 @@ jobs:
- name: Install npm packages
run: npm ci

- name: Lint SCSS
run: npm run lint:scss

- name: Build CSS
run: npm run compile:build
run: npm run compile:css

- name: Build CSS-RTL
run: npm run compile:rtl

- name: Lint JS
run: npm run lint:js

- name: Build JS
run: npm run build

Expand Down
4 changes: 3 additions & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"no-duplicate-selectors": null,
"font-family-no-duplicate-names": null,
"selector-class-pattern": null,
"function-url-quotes": null
"function-url-quotes": null,
"declaration-property-unit-allowed-list": null,
"scss/no-global-function-names": null
}
}
16 changes: 9 additions & 7 deletions sass/_accordion.scss
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
.c-accordion{
&__title{
.c-accordion {

&__title {

font-size: 25px;
font-family: PTSans !important;

&:before{
&::before {
display: none !important;
}
&:after{

&::after {

content: ">";
padding-left: 1em;
font-weight: bold;
position:relative;
font-weight: 700;
position: relative;
}
}
}

18 changes: 11 additions & 7 deletions sass/_archives.scss
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
.archive{
a{
.archive {

a {
text-decoration: none;
}
article{

article {
border-radius: $border-radius;
overflow: hidden;
}

.page-header{
.page-header {
padding-top: 80px;
padding-bottom: 80px;
}

&-loop{
.entry-content{
a{
&-loop {

.entry-content {

a {
color: $body-color;
}
}
Expand Down
7 changes: 3 additions & 4 deletions sass/_colors.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@

.bg-lightgreen{
.bg-lightgreen {
background-color: $lightgreen;
}

.bg-darkgreen{
.bg-darkgreen {
background-color: $darkgreen;
}

Expand All @@ -20,4 +19,4 @@
.has-#{$name}-hover-background-color:hover {
background-color: $code !important;
}
}
}
96 changes: 51 additions & 45 deletions sass/_comments.scss
Original file line number Diff line number Diff line change
@@ -1,134 +1,140 @@
.comment{
&-list{
list-style-type: none;
.comment {

&-list {
list-style-type: none;
}

&s-title{
&s-title {
text-align: center;
margin: 50px 0;
}

.children{
.children {
border-left: 2px solid $primary;
margin-bottom: 65px;
margin-left: 0;

@include media-breakpoint-up(md) {
margin-left: 1.5em;
}

}

&-body{
footer{
&-body {

footer {
display: block;

@include media-breakpoint-up(md) {
display: flex;
}

.says{
.says {
display: none;
}

.comment{
&-author{
.comment {

&-author {

@include media-breakpoint-up(md) {
border-right: 1px solid $black;
padding-right: 10px;
margin-right: 10px;
}
}
&-metadata{

&-metadata {
margin-bottom: 10px;

@include media-breakpoint-up(md) {
margin-bottom: 0;
}
a{
color:inherit;

a {
color: inherit;
text-decoration: none;
}
}
}
}

.reply{
.reply {
text-align: right;
}
.comment-reply-link{

.comment-reply-link {
font-style: italic;
text-transform: uppercase;
color: $black;
text-decoration: none;
font-weight: bold;
font-weight: 700;
}
}

&-reply{
&-title{
&-reply {

&-title {
text-align: center;
}
}


&-respond{
&-respond {

background-color: $white;
padding: 30px;
border-radius: $border-radius;


label{
label {
display: block;
}

.comment-form-cookies-consent{
.comment-form-cookies-consent {
display: flex;
align-items: center;

input{
input {
width: 50px;
height: 50px;
margin-right: 1em;
}
label{

label {
display: inline;
font-size: 15px;
}
}

input[type=url],
input[type=text],
input[type=email]{
input[type="url"],
input[type="text"],
input[type="email"] {
width: 100%;
}
}

&-form{
&-comment{
&-form {

}
&-comment {}

&-author,
&-email,
&-url{
&-author,
&-email,
&-url {}

}
&-meta {}

&-meta{
&-cookies-consent {

}

&-cookies-consent{

label{

}
}
label {}
}
}
}

.form-submit{
.form-submit {
text-align: right;

input{
input {
background-color: #46962b;
text-transform: uppercase;
font-size: 1rem;
Expand All @@ -140,6 +146,6 @@
}
}

.comments-area{
.comments-area {
min-height: 100px;
}
Loading