Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force TypeScript usage of NPM events dep instead of Node built-in events module #298

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Jun 10, 2024

Details

  • Generated TS types should not depend on Node types.
  • So let's force module resolution to take and read events from the NPM events module.

…events` module

### Details

- Generated TS types should not depend on Node types.
- So let's force module resolution to take and read `events` from the NPM **events** module.
@ibc ibc requested a review from jmillan June 10, 2024 09:27
@ibc ibc merged commit c716e66 into v3 Jun 10, 2024
6 checks passed
@ibc ibc deleted the force-ts-usage-of-events-dep branch June 10, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant