-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abseil 20240722.0 LTS upgrade #1456
Abseil 20240722.0 LTS upgrade #1456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but I see CI is failing in some Ubuntu
Errors related to hash_policy_traits: abseil/abseil-cpp#1634 |
Yup. But we cannot disable the |
The bug in GCC that causes the problem hasn't received any love since 2016 when it was reported... |
Probably worked for me because I built with clang - well, at least we know the deal. |
Yes, as CI shows everything passes but Linux with GCC and address sanitizer |
Is Clang with sanitizer not sufficient? |
I don't know. Perhaps GCC sanitizes more things. |
@jmillan your thoughts here? |
I'm fine with doing sanitization only with clang. Luckily we are using two compilers in CI which are in pair and IMO we are not going to lose anything important. |
@garrettboone @nazar-pc @jmillan I'm doing this to unblock this PR: Well, I tried to push to this original branch but I have no permission so I ended forking it, so I will close this PR since it's included in #1457. |
Currently used abseil release (20230802.1) has a bug preventing compilation for FreeBSD systems. The bug has been fixed in later versions.
Source URLs, hashes, and patches have been updated.
Builds successfully on:
FreeBSD 14.1-RELEASE-p5
FreeBSD clang version 18.1.5