Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module split #134

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Module split #134

merged 5 commits into from
Jan 9, 2019

Conversation

codepitbull
Copy link

This PR adds two new modules, one containing the old Scala driver, the other one the new Kotlin based driver by @oshai. This should start the transition discussewd in #125


image:https://travis-ci.org/vert-x3/vertx-mysql-postgresql-client.svg?branch=master["Build Status", link="https://travis-ci.org/vert-x3/vertx-mysql-postgresql-client"]

This Vert.x client uses the https://github.com/mauricio/postgresql-async[Mauricio Linhares driver] to support
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be changed. not sure if you want to do that as part of this commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codepitbull codepitbull merged commit 78e27d8 into 3.6 Jan 9, 2019
@codepitbull codepitbull deleted the module_split branch January 9, 2019 08:12
@okou19900722
Copy link
Contributor

okou19900722 commented Jan 9, 2019

both modules used jasync. none with mauricio

@codepitbull
Copy link
Author

Holy crap, something went wrong.
Will fix asap.

@codepitbull
Copy link
Author

@okou19900722 thanks for pointing out, it's fixed now.

@okou19900722
Copy link
Contributor

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants