Disable SockJSSocket writeHandler by default #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, when registered, make it local only by default. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
issue/1221
branch
from
f7b4155
to
3244ae3
Compare
|
@pmlopes the failures are unrelated (static handler tests failures) |
|
@pmlopes it seems these tests are failing due to the result of Has the implementation changed in Vert.x core recently? |
|
@pmlopes I had a quick look last week and it seems the failures happen intermittently, depending on the order of tests. Some tests put a I will file a separate issue. |
|
Depends on eclipse-vertx/vert.x#3581 for proper testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1221
Also, when registered, make it local only by default.