added list.pop() in storm (#2027)

Added pop method to list object in storm

synapse/lib/stormtypes.py

@@ -2531,6 +2531,7 @@ def __init__(self, valu, path=None):
     def getObjLocals(self):
         return {
             'has': self._methListHas,
+            'pop': self._methListPop,
             'size': self._methListSize,
             'index': self._methListIndex,
             'length': self._methListLength,
@@ -2575,7 +2576,20 @@ async def _methListHas(self, valu):
 
         return prim in self.valu
 
+    async def _methListPop(self):
+        '''
+        Pop and return the last entry in the list.
+        '''
+        try:
+            return self.valu.pop()
+        except IndexError:
+            mesg = 'The list is empty.  Nothing to pop.'
+            raise s_exc.StormRuntimeError(mesg=mesg)
+
     async def _methListAppend(self, valu):
+        '''
+        Append a value to the list.
+        '''
         self.valu.append(valu)
 
     async def _methListIndex(self, valu):

synapse/tests/test_lib_stormtypes.py

@@ -738,6 +738,9 @@ async def test_storm_lib_list(self):
 
             self.eq('bar', await core.callStorm('$foo = (foo, bar) return($foo.1)'))
             self.eq('foo', await core.callStorm('$foo = (foo, bar) return($foo."-2")'))
+            self.eq('bar', await core.callStorm('$foo = (foo, bar) return($foo.pop())'))
+            with self.raises(s_exc.StormRuntimeError):
+                await core.callStorm('$lib.list().pop()')
 
     async def test_storm_lib_fire(self):
         async with self.getTestCore() as core: