Fix sequencing bug between leadership setting and service initialization #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/synapse into leader-service-bug
Codecov Report
@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
- Coverage 96.12% 96.01% -0.12%
==========================================
Files 139 139
Lines 26505 26557 +52
==========================================
+ Hits 25479 25499 +20
- Misses 1026 1058 +32
Continue to review full report at Codecov.
|
vEpiphyte
reviewed
Jun 19, 2020
vEpiphyte
reviewed
Jun 19, 2020
vEpiphyte
reviewed
Jun 19, 2020
vEpiphyte
reviewed
Jun 19, 2020
vEpiphyte
reviewed
Jun 19, 2020
Revert the deferpost stuff. Add a onPreLeader hook to nexus to provide initialization after leadership but before followerloop. Storm services shouldn't go up and down with the leader/follower.
vEpiphyte
reviewed
Jun 22, 2020
vEpiphyte
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated some cluster-related changes from visi as it intersected.
This includes adding a new NotMsgpackSafe exception for easier debugging.