Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cortex/layer idens prior to migration #1788

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

mikemoritz
Copy link
Contributor

  • Also makes minimum cortex version a hard requirement

@mikemoritz mikemoritz changed the title Check cortex/layer idens Check cortex/layer idens prior to migration Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #1788 into master will decrease coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
- Coverage   96.16%   96.12%   -0.05%     
==========================================
  Files         139      139              
  Lines       26560    26577      +17     
==========================================
+ Hits        25541    25546       +5     
- Misses       1019     1031      +12     
Flag Coverage Δ
#linux 96.12% <92.85%> (-0.05%) ⬇️
#linux_replay 66.00% <0.00%> (-0.19%) ⬇️
Impacted Files Coverage Δ
synapse/tools/migrate_200.py 97.60% <92.85%> (-0.21%) ⬇️
synapse/lib/spawn.py 95.48% <0.00%> (-1.94%) ⬇️
synapse/lib/base.py 92.55% <0.00%> (-0.60%) ⬇️
synapse/lib/agenda.py 94.11% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a3bac...41bbf13. Read the comment docs.

@vEpiphyte vEpiphyte merged commit a665cfd into master Jul 3, 2020
@vEpiphyte vEpiphyte deleted the migr-chkidens branch July 3, 2020 16:40
@vEpiphyte vEpiphyte added the bug label Jul 3, 2020
@vEpiphyte vEpiphyte added this to the v2.2.2 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants