Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly sync when slab replay log gets too big #1838

Merged
merged 6 commits into from
Aug 11, 2020
Merged

Conversation

jnwatson
Copy link
Contributor

Also keep stats on replay log size and commit time.

@jnwatson jnwatson changed the title Explicitly sync when slab replay log gets to big Explicitly sync when slab replay log gets too big Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #1838 into master will increase coverage by 4.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage   86.95%   91.15%   +4.20%     
==========================================
  Files         140      140              
  Lines       27433    27441       +8     
==========================================
+ Hits        23855    25015    +1160     
+ Misses       3578     2426    -1152     
Flag Coverage Δ
#linux 91.15% <100.00%> (+4.20%) ⬆️
#linux_replay 57.38% <90.90%> (-9.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 92.80% <100.00%> (-2.85%) ⬇️
synapse/lib/lmdbslab.py 98.47% <100.00%> (-0.61%) ⬇️
synapse/tools/guid.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/tools/autodoc.py 0.00% <0.00%> (-96.06%) ⬇️
synapse/tools/pullfile.py 0.00% <0.00%> (-91.67%) ⬇️
synapse/cmds/hive.py 18.84% <0.00%> (-81.16%) ⬇️
synapse/lib/stormwhois.py 26.66% <0.00%> (-73.34%) ⬇️
synapse/cmds/cortex.py 39.58% <0.00%> (-59.03%) ⬇️
synapse/models/dns.py 49.15% <0.00%> (-50.85%) ⬇️
synapse/models/telco.py 53.40% <0.00%> (-46.60%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a32dc...36c38bb. Read the comment docs.

@invisig0th invisig0th merged commit e6b1376 into master Aug 11, 2020
@invisig0th invisig0th deleted the lmdb-sync-replay branch August 11, 2020 18:21
@vEpiphyte vEpiphyte added this to the v2.6.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants