Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parent vars in macro.exec #1841

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Support parent vars in macro.exec #1841

merged 3 commits into from
Aug 12, 2020

Conversation

mikemoritz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1841 into master will decrease coverage by 3.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   96.27%   93.20%   -3.07%     
==========================================
  Files         140      140              
  Lines       27455    27453       -2     
==========================================
- Hits        26431    25588     -843     
- Misses       1024     1865     +841     
Flag Coverage Δ
#linux 93.20% <100.00%> (-3.07%) ⬇️
#linux_replay 64.63% <0.00%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormlib/macro.py 100.00% <100.00%> (ø)
synapse/lib/ratelimit.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/lib/crypto/ecc.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/lib/encoding.py 33.33% <0.00%> (-51.59%) ⬇️
synapse/tools/sync_200.py 62.44% <0.00%> (-37.34%) ⬇️
synapse/lib/scope.py 56.25% <0.00%> (-35.00%) ⬇️
synapse/lib/coro.py 69.31% <0.00%> (-29.55%) ⬇️
synapse/models/geospace.py 73.25% <0.00%> (-24.42%) ⬇️
synapse/models/files.py 78.57% <0.00%> (-20.54%) ⬇️
synapse/lib/types.py 79.10% <0.00%> (-18.71%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610bc8a...f3b05db. Read the comment docs.

@invisig0th invisig0th merged commit 457b8d7 into master Aug 12, 2020
@invisig0th invisig0th deleted the bug-macro-vars branch August 12, 2020 14:56
@vEpiphyte vEpiphyte added this to the v2.6.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants