Feature storm httpapi params #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 96.30% 96.36% +0.06%
==========================================
Files 141 141
Lines 27628 27628
==========================================
+ Hits 26606 26623 +17
+ Misses 1022 1005 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vEpiphyte
commented
Aug 20, 2020
| @@ -32,24 +32,14 @@ async def _httpEasyGet(self, url, headers=None, ssl_verify=True): | |||
|
|
|||
| ssl_verify (bool): Perform SSL/TLS verification. Defaults to true. | |||
|
|
|||
| params (dict): Optional parameters which may be passed to the request. | |||
There was a problem hiding this comment.
Since we're passing the params directly through to aiohttp, technically this can be multiple types and I've got tests for each of them; if only to 1) avoid isinstance code and 2) support recurring key options in params
invisig0th
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramsargument to$lib.inet.httpfunctions to send arbitrary request parameters.$lib.inet.http...tests to use that instead of making lots of nodes.