Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model updates to support org IDs, ad IDs, asnet6, and various additional fields #1879

Merged
merged 10 commits into from
Sep 21, 2020

Conversation

invisig0th
Copy link
Contributor

No description provided.

@invisig0th invisig0th changed the title WIP: model updates to support org IDs, ad IDs, and various additional fields model updates to support org IDs, ad IDs, asnet6, and various additional fields Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1879 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
+ Coverage   96.51%   96.58%   +0.07%     
==========================================
  Files         141      141              
  Lines       27698    27698              
==========================================
+ Hits        26732    26753      +21     
+ Misses        966      945      -21     
Flag Coverage Δ
#linux 96.58% <ø> (+0.07%) ⬆️
#linux_replay 66.64% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/auth.py 100.00% <ø> (ø)
synapse/models/inet.py 99.21% <ø> (ø)
synapse/models/infotech.py 100.00% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/person.py 100.00% <ø> (ø)
synapse/models/telco.py 100.00% <ø> (ø)
synapse/models/transport.py 100.00% <ø> (ø)
synapse/common.py 97.10% <0.00%> (+0.32%) ⬆️
synapse/lib/spawn.py 95.48% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878334c...e5c1230. Read the comment docs.

@vEpiphyte vEpiphyte added this to the 2.8.0 milestone Sep 21, 2020
whippit
whippit previously approved these changes Sep 21, 2020
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@invisig0th invisig0th merged commit 6e893dd into master Sep 21, 2020
@invisig0th invisig0th deleted the visi-orgid branch September 21, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants