ensure that storm httpapis tear down runtime tasks if the remote disconnects #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
=======================================
Coverage 96.53% 96.54%
=======================================
Files 139 139
Lines 26058 26062 +4
=======================================
+ Hits 25156 25162 +6
+ Misses 902 900 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
invisig0th
requested changes
Sep 24, 2020
synapse/lib/httpapi.py
Outdated
| @@ -300,11 +300,16 @@ async def data_received(self, chunk): | |||
|
|
|||
| class StormNodesV1(Handler): | |||
|
|
|||
| def on_connection_close(self): | |||
| if self.task: | |||
There was a problem hiding this comment.
This should be if self.task is not None no?
…se into bug_http_storm_close
invisig0th
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.