Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable working under Python 3.8 #1907

Merged
merged 4 commits into from
Oct 9, 2020
Merged

Enable working under Python 3.8 #1907

merged 4 commits into from
Oct 9, 2020

Conversation

jnwatson
Copy link
Contributor

@jnwatson jnwatson commented Oct 8, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1907 into master will increase coverage by 0.09%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
+ Coverage   96.59%   96.69%   +0.09%     
==========================================
  Files         139      139              
  Lines       26225    26412     +187     
==========================================
+ Hits        25331    25538     +207     
+ Misses        894      874      -20     
Flag Coverage Δ
#linux 96.69% <94.73%> (+0.09%) ⬆️
#linux_replay 71.09% <63.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/httpapi.py 94.75% <ø> (-0.02%) ⬇️
synapse/lib/lmdbslab.py 99.59% <ø> (+0.10%) ⬆️
synapse/lib/nexus.py 96.81% <ø> (ø)
synapse/lib/snap.py 94.58% <ø> (-0.17%) ⬇️
synapse/lib/stormsvc.py 97.22% <ø> (ø)
synapse/lib/types.py 97.84% <ø> (+<0.01%) ⬆️
synapse/lib/view.py 96.03% <ø> (+1.47%) ⬆️
synapse/cortex.py 95.99% <75.00%> (+0.19%) ⬆️
synapse/daemon.py 89.57% <100.00%> (ø)
synapse/lib/base.py 95.20% <100.00%> (+2.92%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1043ac...f446a74. Read the comment docs.

@jnwatson jnwatson merged commit 81df2d6 into master Oct 9, 2020
@jnwatson jnwatson deleted the py38 branch October 9, 2020 14:38
@vEpiphyte vEpiphyte added this to the 2.9.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants