Update storm cmdargs 'type' value to allow any model type name #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
+ Coverage 93.42% 96.45% +3.02%
==========================================
Files 139 139
Lines 26508 26513 +5
==========================================
+ Hits 24765 25573 +808
+ Misses 1743 940 -803
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
invisig0th
requested changes
Oct 22, 2020
…t/synapse into storm-argparse-time
…t/synapse into storm-argparse-time
Cisphyx
changed the title
vEpiphyte
reviewed
Oct 22, 2020
| @@ -1838,7 +1864,7 @@ class LimitCmd(Cmd): | |||
|
|
|||
| def getArgParser(self): | |||
| pars = Cmd.getArgParser(self) | |||
| pars.add_argument('count', type=int, help='The maximum number of nodes to yield.') | |||
| pars.add_argument('count', type='int', help='The maximum number of nodes to yield.') | |||
There was a problem hiding this comment.
this is a breaking change we need to be aware of
There was a problem hiding this comment.
should only apply to python storm commands ( since pure storm commands had to be serializeable ) so i'd call it an internal change, but yea. def need to be aware.
invisig0th
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.