Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly plumb getPathObjs #1976

Merged
merged 1 commit into from
Dec 1, 2020
Merged

properly plumb getPathObjs #1976

merged 1 commit into from
Dec 1, 2020

Conversation

invisig0th
Copy link
Contributor

No description provided.

@invisig0th invisig0th added the bug label Dec 1, 2020
@invisig0th invisig0th added this to the v2.12.1 milestone Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1976 (76a0626) into master (485dafc) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   96.80%   96.61%   -0.20%     
==========================================
  Files         146      146              
  Lines       27771    27774       +3     
==========================================
- Hits        26885    26833      -52     
- Misses        886      941      +55     
Flag Coverage Δ
linux 96.61% <100.00%> (-0.13%) ⬇️
linux_replay ?
osx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/jsonstor.py 98.12% <100.00%> (+1.54%) ⬆️
synapse/lib/platforms/darwin.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/lib/thisplat.py 58.33% <0.00%> (-8.34%) ⬇️
synapse/tests/utils.py 93.59% <0.00%> (-2.18%) ⬇️
synapse/cortex.py 95.59% <0.00%> (-0.82%) ⬇️
synapse/lib/hiveauth.py 95.96% <0.00%> (-0.77%) ⬇️
synapse/lib/view.py 95.37% <0.00%> (-0.73%) ⬇️
synapse/lib/link.py 98.78% <0.00%> (-0.61%) ⬇️
synapse/cryotank.py 91.42% <0.00%> (-0.58%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485dafc...76a0626. Read the comment docs.

@vEpiphyte vEpiphyte merged commit d4f7889 into master Dec 1, 2020
@vEpiphyte vEpiphyte deleted the visi-json-gets branch December 1, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants