Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matchdef of tag:tagprop for layer.syncIndexEvents #2010

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

jnwatson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #2010 (4ced635) into master (3a88346) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
- Coverage   96.83%   96.67%   -0.17%     
==========================================
  Files         147      147              
  Lines       28742    28742              
==========================================
- Hits        27832    27785      -47     
- Misses        910      957      +47     
Flag Coverage Δ
linux 96.67% <ø> (-0.17%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/layer.py 98.09% <ø> (-0.07%) ⬇️
synapse/tests/utils.py 93.64% <0.00%> (-2.17%) ⬇️
synapse/lib/spawn.py 96.50% <0.00%> (-0.96%) ⬇️
synapse/cortex.py 95.79% <0.00%> (-0.76%) ⬇️
synapse/lib/hiveauth.py 96.05% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 94.19% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/lmdbslab.py 99.40% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a88346...4ced635. Read the comment docs.

or (etyp in (EDIT_PROP_SET, EDIT_PROP_DEL) and (vals[0] in propm
or f'{form}:{vals[0]}' in propm))
or (etyp in (EDIT_PROP_SET, EDIT_PROP_DEL)
and (vals[0] in propm or f'{form}:{vals[0]}' in propm))
Copy link
Contributor

@invisig0th invisig0th Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it potentially worth memoizing this string construction (here and any other obvious ones) to cut down on new objects in the tight loop?

@invisig0th invisig0th merged commit 7730c27 into master Dec 17, 2020
@invisig0th invisig0th deleted the layrindex-tagprop branch December 17, 2020 01:56
@vEpiphyte vEpiphyte added this to the v2.17.0 milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants