Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require use of deepcopy of storage nodes #2031

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #2031 (8bad266) into master (5ca0611) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
- Coverage   96.76%   96.62%   -0.15%     
==========================================
  Files         148      148              
  Lines       29124    29126       +2     
==========================================
- Hits        28183    28144      -39     
- Misses        941      982      +41     
Flag Coverage Δ
linux 96.62% <100.00%> (-0.15%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 95.75% <100.00%> (-0.76%) ⬇️
synapse/lib/layer.py 98.24% <100.00%> (-0.12%) ⬇️
synapse/lib/msgpack.py 98.38% <100.00%> (+0.05%) ⬆️
synapse/lib/node.py 97.79% <100.00%> (-0.02%) ⬇️
synapse/lib/snap.py 94.82% <100.00%> (-0.02%) ⬇️
synapse/lib/storm.py 98.03% <100.00%> (ø)
synapse/lib/stormtypes.py 97.84% <100.00%> (ø)
synapse/lib/view.py 94.22% <100.00%> (-0.67%) ⬇️
synapse/tests/utils.py 93.66% <0.00%> (-2.16%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0611...8bad266. Read the comment docs.

@invisig0th invisig0th merged commit a233336 into master Dec 28, 2020
@invisig0th invisig0th deleted the visi-sode-deepcopy branch December 28, 2020 21:33
@vEpiphyte vEpiphyte added the bug label Dec 29, 2020
@vEpiphyte vEpiphyte added this to the v2.20.0 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants