Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge perms check to edges.del command #2064

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Add edge perms check to edges.del command #2064

merged 1 commit into from
Jan 29, 2021

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jan 29, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #2064 (1f3f4f8) into master (1b0d36c) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
- Coverage   96.84%   96.70%   -0.15%     
==========================================
  Files         150      150              
  Lines       29870    29874       +4     
==========================================
- Hits        28927    28889      -38     
- Misses        943      985      +42     
Flag Coverage Δ
linux 96.70% <100.00%> (-0.15%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 98.11% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 93.68% <0.00%> (-2.16%) ⬇️
synapse/lib/hiveauth.py 96.06% <0.00%> (-0.75%) ⬇️
synapse/cortex.py 96.01% <0.00%> (-0.71%) ⬇️
synapse/lib/view.py 94.19% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/layer.py 98.06% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0d36c...1f3f4f8. Read the comment docs.

@Cisphyx Cisphyx merged commit bf353f8 into master Jan 29, 2021
@vEpiphyte vEpiphyte added this to the v2.24.0 milestone Jan 29, 2021
@vEpiphyte vEpiphyte deleted the edgesdel-perms branch January 29, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants