risk:outage meta:aggregate and reporter props on ou:industry #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reign-git
reviewed
Oct 24, 2024
Co-authored-by: therealsilence <[email protected]>
reign-git
reviewed
Nov 4, 2024
reign-git
reviewed
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3968 +/- ##
==========================================
- Coverage 96.44% 96.37% -0.08%
==========================================
Files 253 253
Lines 59305 59305
==========================================
- Hits 57198 57153 -45
- Misses 2107 2152 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
invisig0th
changed the title
MichaelSquires
approved these changes
Nov 4, 2024
Cisphyx
reviewed
Nov 4, 2024
Comment on lines
+1088
to
+1089
| ('reporter:name', ('ou:name', {}), { | ||
| 'doc': 'The name of the organization reporting on the outage event.'}), |
There was a problem hiding this comment.
duplicate reporter:name prop
There was a problem hiding this comment.
Thanks! I'll put up another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.