Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the AESEncrypt and AESDecrypt functions work with varbinary instead of varchar ? #58

Open
nicolasriousset opened this issue Feb 15, 2018 · 0 comments

Comments

@nicolasriousset
Copy link

nicolasriousset commented Feb 15, 2018

The encryption_package AESEncrypt function returns a varchar value, while AESDecrypt takes a varchar value to decrypt.

Is there any reason why varchar is used instead of varbinary ? It feels like the latter would make more sense, and would respect the MySQL functions signature.

To keep backward compatibility, instead of simply altering methods signature, one could rely on Vertica function overloading support
However, this would only work for the decrypt function, since overloading cannot be done on the return type.

nicolasriousset added a commit to nicolasriousset/Vertica-Extension-Packages that referenced this issue Feb 15, 2018
…nstead of varchar

AESEncrypt and AESDecrypt functions now work with varbinary instead of varchar
nicolasriousset added a commit to nicolasriousset/Vertica-Extension-Packages that referenced this issue Feb 15, 2018
…-work-with-varbinary-in-addition-to-varchar' into Vocaza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant