Skip to content

Commit

Permalink
Wait for webhook to come up for e2e tests (#67)
Browse files Browse the repository at this point in the history
The e2e tests hit a failure because we had tried to create a VerticaDB before
the webhook was fully up. This is a known issue (#30) with the webhook. We are
going to work around this for now by adding a wait script when the tests issue
make deploy.
  • Loading branch information
spilchen authored Sep 27, 2021
1 parent ab32141 commit 6b954a3
Show file tree
Hide file tree
Showing 3 changed files with 99 additions and 29 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified

deploy-operator: manifests kustomize ## Using helm, deploy the controller to the K8s cluster specified in ~/.kube/config.
helm install --wait -n $(NAMESPACE) $(HELM_RELEASE_NAME) $(OPERATOR_CHART) --set image.name=${OPERATOR_IMG} $(HELM_OVERRIDES)
scripts/wait-for-webhook.sh -n $(NAMESPACE) -t 60

undeploy-operator: ## Using helm, undeploy controller from the K8s cluster specified in ~/.kube/config.
helm uninstall -n $(NAMESPACE) $(HELM_RELEASE_NAME)
Expand Down
29 changes: 0 additions & 29 deletions scripts/wait-for-deploy.sh

This file was deleted.

98 changes: 98 additions & 0 deletions scripts/wait-for-webhook.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
#!/bin/bash

# (c) Copyright [2021] Micro Focus or one of its affiliates.
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# A script that will wait for the webhook to be fully setup. There is a small
# timing window where the pod with the webhook is up and ready, but the webhook
# is not yet able to accept connections. See this issue for more details:
# https://github.com/vertica/vertica-kubernetes/issues/30

SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
REPO_DIR=$(dirname $SCRIPT_DIR)
TIMEOUT=30

function usage() {
echo "usage: $(basename $0) [-n <namespace>] [-t <seconds>]"
echo
echo "Options:"
echo " -n <namespace> Check the webhook in this namespace."
echo " -t <seconds> Specify the timeout in seconds [defaults: $TIMEOUT]"
exit 1
}

while getopts "n:t:h" opt
do
case $opt in
n)
NAMESPACE_OPT="-n $OPTARG"
;;
t)
TIMEOUT=$OPTARG
;;
h)
usage
;;
\?)
echo "ERROR: unrecognized option: -$opt"
usage
;;
esac
done

# First ensure the service object for the webhook exists.
trap "echo 'Failed waiting for webhook service object to exist'" 0 2 3 15
set -o errexit
timeout $TIMEOUT bash -c -- "\
while ! kubectl get $NAMESPACE_OPT svc --no-headers verticadb-operator-webhook-service 2> /dev/null | grep -cq 'service'; \
do \
sleep 0.1; \
done"
set +o errexit
trap 1> /dev/null

# Next, to validate the webhook exists, we will continually create/delete a
# VerticaDB. If it succeeds, then we assume the webhook is up and running.
# This depends on the webhook config having the 'failurePolicy: Fail' set.

SELECTOR_KEY=vertica.com/use
SELECTOR_VAL=wait-for-webhook
SELECTOR=$SELECTOR_KEY=$SELECTOR_VAL

MANIFEST=$(mktemp)

cat <<EOF > $MANIFEST
apiVersion: vertica.com/v1beta1
kind: VerticaDB
metadata:
generateName: wait-for-webhook-
labels:
$SELECTOR_KEY: $SELECTOR_VAL
spec:
image: "vertica/vertica-k8s:latest"
initPolicy: ScheduleOnly
subclusters:
- name: sc1
size: 1
EOF

# Delete old manifests, but likely won't be there so eat the error.
kubectl delete $NAMESPACE_OPT vdb -l $SELECTOR 2> /dev/null 1> /dev/null || :

trap "kubectl delete $NAMESPACE_OPT vdb -l $SELECTOR; rm $MANIFEST" 0 2 3 15 # Ensure deletion on script exit"

timeout $TIMEOUT bash -c -- "\
while ! kubectl create $NAMESPACE_OPT -f $MANIFEST 2> /dev/null; \
do \
sleep 0.1; \
done"

0 comments on commit 6b954a3

Please sign in to comment.