Address Matt' comments

PROJECT

@@ -67,4 +67,8 @@ resources:
   kind: VerticaScrutinize
   path: github.com/vertica/vertica-kubernetes/api/v1beta1
   version: v1beta1
+  webhooks:
+    defaulting: true
+    validation: true
+    webhookVersion: v1
 version: "3"

tests/e2e-leg-6/verify-vrpq-conditions/35-create-vrpq-with-start-timestamp-filter.yaml → tests/e2e-leg-6/verify-vrpq-conditions/20-create-vrpq-with-filter.yaml

@@ -11,9 +11,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-apiVersion: kuttl.dev/v1beta1
-kind: TestStep
-commands:
-  - script: |-
-      export STARTTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')
-      sh -c "envsubst < vrpq-start-timestamp.yaml | kubectl apply -n $NAMESPACE -f -"
+apiVersion: vertica.com/v1beta1
+kind: VerticaRestorePointsQuery
+metadata:
+  name: archive-query
+spec:
+  verticaDBName: archive-query
+  filterOptions:
+    startTimestamp: "2024-02-18"

tests/e2e-leg-6/verify-vrpq-conditions/25-assert.yaml

@@ -0,0 +1,21 @@
+# (c) Copyright [2021-2023] Open Text.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: vertica.com/v1beta1
+kind: VerticaRestorePointsQuery
+metadata:
+  name: archive-query
+spec:
+  verticaDBName: archive-query
+  filterOptions:
+    startTimestamp: "2024-02-18"

tests/e2e-leg-6/verify-vrpq-conditions/20-assert.yaml → tests/e2e-leg-6/verify-vrpq-conditions/40-create-vrpq-with-start-timestamp-filter.yaml

@@ -15,5 +15,5 @@ apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
   - script: |-
-      export STARTTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')
+      export STARTTIMESTAMP="$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')"
       sh -c "envsubst < vrpq-start-timestamp.yaml | kubectl apply -n $NAMESPACE -f -"

tests/e2e-leg-6/verify-vrpq-conditions/45-create-vrpq-with-end-timestamp-filter.yaml → tests/e2e-leg-6/verify-vrpq-conditions/50-create-vrpq-with-end-timestamp-filter.yaml

@@ -15,5 +15,5 @@ apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
   - script: |-
-      export ENDTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')
+      export ENDTIMESTAMP="$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')"
       sh -c "envsubst < vrpq-end-timestamp.yaml | kubectl apply -n $NAMESPACE -f -"

tests/e2e-leg-6/verify-vrpq-conditions/55-create-vrpq-with-both-timestamps-filter.yaml → tests/e2e-leg-6/verify-vrpq-conditions/60-create-vrpq-with-both-timestamps-filter.yaml

@@ -15,6 +15,6 @@ apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
   - script: |-
-      export STARTTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')
-      export ENDTIMESTAMP=$STARTTIMESTAMP
+      export STARTTIMESTAMP="$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db") | .timestamp')"
+      export ENDTIMESTAMP="$STARTTIMESTAMP"
       sh -c "envsubst < vrpq-both-timestamps.yaml | kubectl apply -n $NAMESPACE -f -"

tests/e2e-leg-6/verify-vrpq-conditions/65-create-vrpq-with-both-timestamps-filter.yaml → tests/e2e-leg-6/verify-vrpq-conditions/70-create-vrpq-with-both-timestamps-filter.yaml

@@ -15,6 +15,6 @@ apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
   - script: |-
-      export STARTTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==2 and .archive=="db") | .timestamp' | cut -d ' ' -f 1)
-      export ENDTIMESTAMP=$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db2") | .timestamp' | cut -d ' ' -f 1)
+      export STARTTIMESTAMP="$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==2 and .archive=="db") | .timestamp' | cut -d ' ' -f 1)"
+      export ENDTIMESTAMP="$(kubectl get vrpq archive-query -o json -n $NAMESPACE | jq -r '.status.restorePoints[] | select(.index==1 and .archive=="db2") | .timestamp' | cut -d ' ' -f 1)"
       sh -c "envsubst < vrpq-both-date-only-timestamps.yaml | kubectl apply -n $NAMESPACE -f -"