Image change can be marked complete before restart of the pods #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2021 10:34
|
fyi @roypaulin, this will fix intermittent failures in the upgrade-vertica-ks-1 e2e testcase |
|
looks good. but checks were not successful. I guess it has nothing to do with the changes. |
|
There is a problem building the opm package. It is affecting all builds, so nothing related to this change. I'm looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a timing window during upgrade where we can indicate the image change has finished before completing the restart of the pods. There is a check during the restart portion that calls
areAllPodsRunningAndZeroInstalled. This returns true if none of the pods exist yet, which is not correct. State that the function uses was being set after checking if the pod exists. If the pod doesn't exist, the state was left unset. The timing hole is closed now that the state is being set correctly.