Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online image change: new webhook rules #141

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Online image change: new webhook rules #141

merged 4 commits into from
Jan 14, 2022

Conversation

spilchen
Copy link
Collaborator

This adds rules to the webhook for online image change:

  • prevent changes to upgradePolicy when imageChange is in progress
  • transient subcluster template: isPrimary == false, name cannot be an existing subcluster, size > 0 if name present
  • transient subcluster cannot be added/removed during an online image change
  • if multiple subclusters share a ServiceName, service specific things must be common between them (serviceType, NodePort, externalIPs, etc).

@spilchen spilchen self-assigned this Jan 14, 2022
roypaulin
roypaulin reviewed Jan 14, 2022
View reviewed changes
api/v1beta1/verticadb_webhook.go Outdated
}
}
}
// Set a flag so that we don't porcess this service name in another subcluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant "process" here

roypaulin
roypaulin reviewed Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@roypaulin roypaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@spilchen spilchen merged commit e7d2b2e into vertica:online-upgrade Jan 14, 2022
@spilchen spilchen deleted the webhook-online-upgrade branch January 14, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypaulin roypaulin roypaulin left review comments

Assignees

@spilchen spilchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spilchen @roypaulin