Online image change: adding drain logic #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds drain logic so that we wait for active connections to disappear before taking down a subcluster. I added finer granular messaging for imageChangeStatus so that we will have a clear idea if it is waiting for the drain of a particular subcluster.
This change involves sorting the output from sc_finder. This was necessary to match up the status message with order that we will process the subclusters.
Also including a fix that waits for the transient pod to be in a ready state. There was a small timing window where we started to route client traffic to the transient before it was ready. The ready probe is run every 10 seconds, so there was a window where vertica was up but k8s didn't yet know about it.
A new e2e test was added to make sure draining works for the primary and secondary subclusters.