Operator pod readiness probe to wait for webhook #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller-runtime added a health check that will return only when the webhook is up. However, it isn't enabled by default. Instead we just use the normal 'ping' checking, which returns as soon as the pod is running. This commit is to change the readiness probe to use the one in controller-runtime that waits for the webhook. As part of this, I removed the manual webhook check that we use for the e2e tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller-runtime added a health check that will return only when the webhook is up. However, it isn't enabled by default. Instead we just use the normal 'ping' checking, which returns as soon as the pod is running. This commit is to change the readiness probe to use the one in controller-runtime that waits for the webhook.
As part of this, I removed the manual webhook check that we use for the e2e tests.
Closes #30