Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation to suspend reconcile on a CR #404

Merged
merged 1 commit into from
May 24, 2023

Conversation

spilchen
Copy link
Collaborator

This adds the ability to suspend all reconcile activity against a custom resource. This aids in debugging because the operator uses an infinity retry model (i.e. keep retrying the reconcile and use an exponential back-off for repeated failures). This works great unless you want to dig into a specific behaviour that you are seeing.

If any of the CRs (VerticaDB, VerticaAutoscaler, EventTrigger) have the vertica.com/pause annotation set to true, then no further reconcile will get scheduled for the CR.

This also swaps the create DB parameter --force-cleanup-on-failure with --force-removal-at-creation. It has the same affect, but if you have the operator paused you can see the left over log files from a failed create.

@spilchen spilchen requested a review from roypaulin May 23, 2023 17:30
@spilchen spilchen self-assigned this May 23, 2023
apiVersion: v1
kind: Pod
metadata:
name: vdb-label-ant-cluster1-0
Copy link
Collaborator

@roypaulin roypaulin May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the pause annotation would prevent the operator to start the pod.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller for the statefulset isn't paused. So, the pod will still come up. We will never restart vertica in the pod though because the operator is paused.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@spilchen spilchen merged commit 291b7f9 into vertica:main May 24, 2023
@spilchen spilchen deleted the spilchen/suspend-annotation branch May 24, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants