CI changes for new k8s images

[chinhtranvan]

There is some image changes for this PR

• remove the nokeys image from the pipeline and NO_KEYS env var usage
• GH actions to stop using latest-master for vcluster tests. Instead use full or minimal, depending on the leg.

[spilchen]

Looks good. I just had minor comments. It's too bad the e2e pipeline is slow today, we could have gotten a few runs in.

[spilchen]

run some e2e legs against a released vertica-k8s image (vertica/vertica-k8s:23.3.0-0)

I never saw a change for this. If so, it's fine to leave off of this PR. I think we have enough here.

[chinhtranvan]

run some e2e legs against a released vertica-k8s image (vertica/vertica-k8s:23.3.0-0)

I never saw a change for this. If so, it's fine to leave off of this PR. I think we have enough here.

Yes, I will leave off of this PR

[chinhtranvan]

The e2e test looks weird. I'm trying to understand why there is a 'no such file or directory' error when trying to open full-vertica-image/full-vertica-image.tar. Do we need to wait for JenKins to trigger GitHub CI?

[spilchen]

This is needed so that the full image is available for later stages.

[spilchen]

The e2e test looks weird. I'm trying to understand why there is a 'no such file or directory' error when trying to open full-vertica-image/full-vertica-image.tar. Do we need to wait for JenKins to trigger GitHub CI?

There is a missing actions/upload-artifact step. Something like this is needed:

    - uses: actions/upload-artifact@v3
      if: ${{ github.event_name == 'pull_request' }}
      with:
        name: full-vertica-image
        path: full-vertica-image.tar

[chinhtranvan]

The e2e test looks weird. I'm trying to understand why there is a 'no such file or directory' error when trying to open full-vertica-image/full-vertica-image.tar. Do we need to wait for JenKins to trigger GitHub CI?

There is a missing actions/upload-artifact step. Something like this is needed:

    - uses: actions/upload-artifact@v3
      if: ${{ github.event_name == 'pull_request' }}
      with:
        name: full-vertica-image
        path: full-vertica-image.tar

Oh, I remember why we don't need the path full-vertica-image.tar—we encountered this problem before. For v2-vertica-image, we won't push the image because the RPM we use is too old. Therefore, there's no need to save it under full-vertica-image/full-vertica-image.tar and load it later. We just need to pull the image. Reference PR: https://github.com/vertica/vertica-kubernetes/pull/440/files

After skip loading the images, we passed all e2e vcluster tests, only have problems for AT tests, I see errors in AT tests
scripts/push-to-kind.sh: option requires an argument -- i
ERROR: unrecognized option: -?

[chinhtranvan]

The e2e test looks weird. I'm trying to understand why there is a 'no such file or directory' error when trying to open full-vertica-image/full-vertica-image.tar. Do we need to wait for JenKins to trigger GitHub CI?

There is a missing actions/upload-artifact step. Something like this is needed:

    - uses: actions/upload-artifact@v3
      if: ${{ github.event_name == 'pull_request' }}
      with:
        name: full-vertica-image
        path: full-vertica-image.tar

Oh, I remember why we don't need the path full-vertica-image.tar—we encountered this problem before. For v2-vertica-image, we won't push the image because the RPM we use is too old. Therefore, there's no need to save it under full-vertica-image/full-vertica-image.tar and load it later. We just need to pull the image. Reference PR: https://github.com/vertica/vertica-kubernetes/pull/440/files

After skip loading the images, we passed all e2e vcluster tests, only have problems for AT tests, I see errors in AT tests scripts/push-to-kind.sh: option requires an argument -- i ERROR: unrecognized option: -?

Update: just fix the problem, build-e2e.yml

The e2e test looks weird. I'm trying to understand why there is a 'no such file or directory' error when trying to open full-vertica-image/full-vertica-image.tar. Do we need to wait for JenKins to trigger GitHub CI?

There is a missing actions/upload-artifact step. Something like this is needed:

    - uses: actions/upload-artifact@v3
      if: ${{ github.event_name == 'pull_request' }}
      with:
        name: full-vertica-image
        path: full-vertica-image.tar

Oh, I remember why we don't need the path full-vertica-image.tar—we encountered this problem before. For v2-vertica-image, we won't push the image because the RPM we use is too old. Therefore, there's no need to save it under full-vertica-image/full-vertica-image.tar and load it later. We just need to pull the image. Reference PR: https://github.com/vertica/vertica-kubernetes/pull/440/files

After skip loading the images, we passed all e2e vcluster tests, only have problems for AT tests, I see errors in AT tests scripts/push-to-kind.sh: option requires an argument -- i ERROR: unrecognized option: -?

Just fix the problem: some previous changes in build-image.yml caused an empty Vertica Image. All comments have been addressed with successful e2e tests. After this CI is merged, I will go back to Jenkin to trigger CI.