Add restore parameters to v1 API #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
reviewed
Dec 18, 2023
spilchen
reviewed
Dec 18, 2023
Co-authored-by: Roy Paulin <[email protected]>
roypaulin
reviewed
Dec 19, 2023
roypaulin
reviewed
Dec 19, 2023
roypaulin
reviewed
Dec 19, 2023
spilchen
reviewed
Dec 19, 2023
spilchen
approved these changes
Dec 20, 2023
roypaulin
approved these changes
Dec 20, 2023
chinhtranvan
pushed a commit
that referenced
this pull request
Jan 27, 2024
- add `RestorePointPolicy` type in `Spec` - `Archive` must be specified if a restore is intended - one of `ID` and `Index` must be specified (`Index` assumed to be 1-based) - webhook rules to validate `RestorePointPolicy` - revivedb_reconciler checks whether restore is supported given the server version and deployment method - must use vclusterops and has server version greater than v24.2.0 --------- Co-authored-by: Roy Paulin <[email protected]>
chinhtranvan
pushed a commit
that referenced
this pull request
Jan 27, 2024
- add `RestorePointPolicy` type in `Spec` - `Archive` must be specified if a restore is intended - one of `ID` and `Index` must be specified (`Index` assumed to be 1-based) - webhook rules to validate `RestorePointPolicy` - revivedb_reconciler checks whether restore is supported given the server version and deployment method - must use vclusterops and has server version greater than v24.2.0 --------- Co-authored-by: Roy Paulin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestorePointPolicytype inSpecArchivemust be specified if a restore is intendedIDandIndexmust be specified (Indexassumed to be 1-based)RestorePointPolicy