Add empty controller and API for VerticaRestorePoints #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinhtranvan
changed the title
|
This has to merge into vnext. I changed the base of the PR, but I see a bunch of changes in there that you probably didn't do. I would suggest that you rebase with vnext and force push the changes up to GitHub. |
spilchen
reviewed
Dec 19, 2023
chinhtranvan
force-pushed
the
chinh/add-empty-controller-and-API
branch
from
682325d
to
50142f0
Compare
chinhtranvan
force-pushed
the
chinh/add-empty-controller-and-API
branch
from
50142f0
to
c226abe
Compare
|
I'm not sure about the scorecard tests; I have run them successfully on my local machine using the command but Github CI complains this https://github.com/vertica/vertica-kubernetes/actions/runs/7264951541/job/19793584148?pr=643 That happens because |
|
Update, I added 'RestorePoints' to the status and changed the resource to address the issue. However, please feel free to let me know if there is a bettern name for status field |
spilchen
reviewed
Dec 19, 2023
This is fine for now. I expect to fill in valid status fields later. |
chinhtranvan
force-pushed
the
chinh/add-empty-controller-and-API
branch
from
8db7181
to
9cf58a5
Compare
spilchen
reviewed
Dec 19, 2023
helm-charts/verticadb-operator/tests/kind-concurrency_test.yaml
Outdated
Show resolved
Hide resolved
chinhtranvan
added a commit
that referenced
this pull request
Jan 27, 2024
This PR build out the stub for an empty controller to handle the VerticaRestorePointsQuery API. It does not include a webhook, as there are no defined rules for transitioning the Custom Resource (CR), given that the spec portion contains only two fields. The operator can observe the new API, initiate a reconciliation iteration, and take no action, as we have set nil for the actors during this implementation phase --------- Co-authored-by: Matt Spilchen <[email protected]>
chinhtranvan
added a commit
that referenced
this pull request
Jan 27, 2024
This PR build out the stub for an empty controller to handle the VerticaRestorePointsQuery API. It does not include a webhook, as there are no defined rules for transitioning the Custom Resource (CR), given that the spec portion contains only two fields. The operator can observe the new API, initiate a reconciliation iteration, and take no action, as we have set nil for the actors during this implementation phase --------- Co-authored-by: Matt Spilchen <[email protected]>
chinhtranvan
added a commit
that referenced
this pull request
Feb 17, 2024
This PR creates a webhook for the new VerticaRestorePointQuery CR to catch the checks early. There is some webhook part that is added in #643."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build out the stub for an empty controller to handle the VerticaRestorePointsQuery API. It does not include a webhook, as there are no defined rules for transitioning the Custom Resource (CR), given that the spec portion contains only two fields. The operator can observe the new API, initiate a reconciliation iteration, and take no action, as we have set nil for the actors during this implementation phase