Avoid deploying the operator with default label #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 12, 2024 10:41
Any operator that is built with the operator-sdk framework will have default selector labels added for the operator like this: control-plane: controller-manager When the operator is deployed in the same namespace as other operator, that also continue using the default label, then the service object for the operator fails to work. It will route webhook requests to the wrong pod. This change is to use the following label instead: control-plane: verticadb-operator I also took the opportunity to rename the operator objects. The deployment object was renamed from verticadb-operator-controller-manager to verticadb-operator-manager.
We changed the serviceAccount for pods with the new 2.0.2 operator. So, some operator upgrade tests can fail due to a caching issue. The statefulset was updated, but the sts controller was still trying to use the old serviceaccount. I could have fixed this by increasing the timeout of the test, but I opted to delete the sts to avoid the cache issue.
roypaulin
reviewed
Feb 13, 2024
| @@ -15,7 +15,7 @@ apiVersion: v1 | |||
| kind: Pod | |||
| metadata: | |||
| labels: | |||
| control-plane: controller-manager | |||
| control-plane: matt | |||
There was a problem hiding this comment.
Actulally it is. With the change of the control-plane label, it can now be templated in the helm chart. So, in this testcase, which sets the nameOverride parameter, the label will be set to the value of that parameter.
roypaulin
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any operator that is built with the operator-sdk framework will have default selector labels added for the operator like this:
When the operator is deployed in the same namespace as other operator, that also continue using the default label, then the service object for the operator fails to work. The service object is used by the webhook, so it will route webhook requests to the wrong pod.
This change is to use the following label instead:
I also took the opportunity to rename the operator objects. The deployment object was renamed from
verticadb-operator-controller-managertoverticadb-operator-manager.Closes #694