Run scrutinize in its own pod #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure about using the same serviceaccount and podsecuritycontext on verticapods and scrutinize pod. Were you planning for scrutinize to have its own? |
spilchen
reviewed
Feb 15, 2024
spilchen
approved these changes
Feb 16, 2024
| if vinf.IsOlder(v1.ScrutinizeDBPasswdInSecretMinVersion) { | ||
| ver, _ := s.Vdb.GetVerticaVersionStr() | ||
| s.VRec.Eventf(s.Vscr, corev1.EventTypeWarning, events.VclusterOpsScrutinizePasswdInSecretNotSupported, | ||
| "The server version %s does not support vclusterOps scrutinize reading db password from secret", ver) |
There was a problem hiding this comment.
Can we shorten this to say it only runs with 24.2.0?
Suggested change
| "The server version %s does not support vclusterOps scrutinize reading db password from secret", ver) | |
| "The server version %s is not supported with VerticaScrutinize. The minimum server version it supports is %s.", ver, v1.ScrutinizeDBPasswdInSecretMinVersion) |
|
|
||
| if vinf.IsOlder(v1.ScrutinizeDBPasswdInSecretMinVersion) { | ||
| ver, _ := s.Vdb.GetVerticaVersionStr() | ||
| s.VRec.Eventf(s.Vscr, corev1.EventTypeWarning, events.VclusterOpsScrutinizePasswdInSecretNotSupported, |
There was a problem hiding this comment.
Suggest we reuse the event. It all means the same thing, we don't support the deployment.
Suggested change
| s.VRec.Eventf(s.Vscr, corev1.EventTypeWarning, events.VclusterOpsScrutinizePasswdInSecretNotSupported, | |
| s.VRec.Eventf(s.Vscr, corev1.EventTypeWarning, events.VclusterOpsScrutinizeNotSupported, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VerticaScrutinize resource is created, the operator:
PASSWORD_NAMESPACE,PASSWORD_NAME) to allow vcluster scrutinize to read the db password from secret.Once the pod is created, a new reconciler(
PodPollingReconciler) will wait for scrutinize to finish and update status condition