Internal improvement for Autocommit (#468)

vertica · Oct 25, 2022 · b66ad1a · b66ad1a
1 parent c7c68ce
commit b66ad1a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/vertica_python/vertica/connection.py b/vertica_python/vertica/connection.py
@@ -327,10 +327,6 @@ def __init__(self, options=None):
                      self.options['host'], self.options['port']))
         self.startup_connection()
 
-        # Initially, for a new session, autocommit is off
-        if self.options['autocommit']:
-            self.autocommit = True
-
         self._logger.info('Connection is ready')
 
     #############################################
@@ -385,6 +381,7 @@ def cursor(self, cursor_type=None):
     @property
     def autocommit(self):
         """Read the connection's AUTOCOMMIT setting from cache"""
+        # For a new session, autocommit is off by default
         return self.parameters.get('auto_commit', 'off') == 'on'
 
     @autocommit.setter
@@ -805,9 +802,10 @@ def startup_connection(self):
         session_label = self.options['session_label']
         os_user_name = DEFAULT_USER if DEFAULT_USER else ''
         password = self.options['password']
+        autocommit = self.options['autocommit']
         binary_transfer = self.options['binary_transfer']
 
-        self.write(messages.Startup(user, database, session_label, os_user_name, binary_transfer))
+        self.write(messages.Startup(user, database, session_label, os_user_name, autocommit, binary_transfer))
 
         while True:
             message = self.read_message()

diff --git a/vertica_python/vertica/messages/frontend_messages/startup.py b/vertica_python/vertica/messages/frontend_messages/startup.py
@@ -55,7 +55,7 @@
 class Startup(BulkFrontendMessage):
     message_id = None
 
-    def __init__(self, user, database, session_label, os_user_name, binary_transfer):
+    def __init__(self, user, database, session_label, os_user_name, autocommit, binary_transfer):
         BulkFrontendMessage.__init__(self)
 
         try:
@@ -79,6 +79,7 @@ def __init__(self, user, database, session_label, os_user_name, binary_transfer)
             b'client_os': os_platform,
             b'client_os_user_name': os_user_name,
             b'client_pid': pid,
+            b'autocommit': 'on' if autocommit else 'off',
             b'binary_data_protocol': '1' if binary_transfer else '0', # Defaults to text format '0'
         }