Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak related to stats collection #14

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix memory leak related to stats collection #14

merged 1 commit into from
Aug 2, 2021

Conversation

zdmytriv
Copy link

@zdmytriv zdmytriv commented Aug 2, 2021 •
edited
Loading

zdmytriv
zdmytriv commented Aug 2, 2021
View reviewed changes
src/config/config_impl.go
rateLimitKey := domain + "." + this.descriptorToKey(descriptor)
//rateLimitKey := domain + "." + this.descriptorToKey(descriptor)
// when ip is unique for each request it generates too many stats counters and never cleans them up
rateLimitKey := domain + ".override"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envoyproxy#275

@zdmytriv zdmytriv merged commit df167d4 into master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nestorsokil nestorsokil nestorsokil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdmytriv @nestorsokil