fix: errRequestHeaderListSize #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenhaocs
reviewed
Feb 3, 2023
thrift/lib/go/thrift/http_client.go
Outdated
| @@ -213,8 +213,8 @@ func (p *HTTPClient) Flush() error { | |||
| if err != nil { | |||
| return NewTransportExceptionFromError(err) | |||
| } | |||
| p.header.Add("Content-Type", "application/x-thrift") | |||
| req.Header = p.header | |||
| req.Header = p.header.Clone() | |||
There was a problem hiding this comment.
Any special reason of cloning the p.header?
There was a problem hiding this comment.
Discussed offline. This is to make all p.header unchanged since requests will reuse this.
Aiee
approved these changes
Feb 3, 2023
wenhaocs
approved these changes
Feb 3, 2023
veezhang
force-pushed
the
fix-errRequestHeaderListSize
branch
from
bd25cde
to
4d63f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: