Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware: add ReserveRequest and ReserveResponseWriter #18

Merged
merged 1 commit into from
May 16, 2022

Conversation

veezhang
Copy link
Contributor

  • support reserve http.Request
  • support reserve http.ResponseWriter
  • with 100% test coverage

In some cases, we need to use http.Request and http.ResponseWriter in our business code.
For examples:

  • file download
  • Parse the request yourself (preferably using framework parse)

@veezhang veezhang requested a review from nianiaJR May 13, 2022 10:18
@codecov-commenter
Copy link

Codecov Report

Merging #18 (b71aaf6) into master (97328dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #18    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           13        16     +3     
  Lines          624       769   +145     
==========================================
+ Hits           624       769   +145     
Impacted Files Coverage Δ
middleware/assets.go 100.00% <100.00%> (ø)
middleware/keep_request_responce.go 100.00% <100.00%> (ø)
middleware/middleware.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a180a93...b71aaf6. Read the comment docs.

Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants