-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the Dockerfile for Centos #76
Merged
yixinglu
merged 9 commits into
vesoft-inc:master
from
Shinji-IkariG:Shinji-IkariG-patch-1
Feb 17, 2023
Merged
Split the Dockerfile for Centos #76
yixinglu
merged 9 commits into
vesoft-inc:master
from
Shinji-IkariG:Shinji-IkariG-patch-1
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt to the mold installation method of Centos7 * Remove Centos8 related steps
* Workflow for removing Centos7
* Repair the workflow after removing the system version judgment
* Adapt to the updated matrix of Dockerfile * Add automatic trigger action based on merge event
yixinglu
reviewed
Feb 14, 2023
Dockerfile.centos7
Outdated
#Install mold | ||
RUN mkdir /usr/local/mold && wget -qO- https://oss-cdn.nebula-graph.com.cn/toolset/mold/mold-1.10.1-$(uname -m)-linux.tar.gz | tar xzf - --strip-components=1 -C /usr/local/mold/ | ||
RUN rm /usr/lib64/libstdc++.so.6 | ||
RUN ln -s /opt/vesoft/toolset/gcc/9.3.0/lib64/libstdc++.so.6 /usr/lib64/libstdc++.so.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ln -snf
yixinglu
reviewed
Feb 14, 2023
Dockerfile.centos8
Outdated
RUN yum clean all \ | ||
&& rm -rf /var/cache/yum | ||
RUN yum --enablerepo=powertools install -y ninja-build | ||
RUN yum clean all && rm -rf /var/cache/yum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge the layer
* Update the referenced third-party action version
fix format
* Optimize docker image volume and perform correct cleanup operations
Separate ninja-build installation steps
yixinglu
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: