support oracle datasource #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomJoe211
added
the
doc affected
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
============================================
- Coverage 55.05% 54.32% -0.74%
Complexity 76 76
============================================
Files 17 17
Lines 1344 1364 +20
Branches 255 258 +3
============================================
+ Hits 740 741 +1
- Misses 474 492 +18
- Partials 130 131 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
close issue #7 |
|
Why don't reuse MySQLReader and refine to JDBC Reader ? |
|
oracle configurations need to added to Configs.scala too |
jievince
approved these changes
Aug 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.