Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Flink 1.13 #38

Closed
wey-gu opened this issue Nov 24, 2021 · 14 comments
Closed

Add Support for Flink 1.13 #38

wey-gu opened this issue Nov 24, 2021 · 14 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wey-gu
Copy link

wey-gu commented Nov 24, 2021

The maintainer doesn't have the bandwidth for this now, hopefully, anyone could help/volunteer on this.

@wey-gu wey-gu changed the title Could we support flink 1.13, please? Add Support for Flink 1.13 Nov 25, 2021
@wey-gu wey-gu added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 25, 2021
@JimWen
Copy link

JimWen commented Apr 9, 2022

please check this pr
Add Support up to Flink 1.14
#52

@markjoin123
Copy link

May I ask when will you merge spending flink 1.14 version?

@spike-liu
Copy link
Contributor

@wey-gu another implementation has been included in #57. Please feel free to review.

@wey-gu
Copy link
Author

wey-gu commented Jun 17, 2022

@wey-gu another implementation has been included in #57. Please feel free to review.

Amazing, this is extra awesome! Thanks!!

@spike-liu
Copy link
Contributor

@wey-gu another implementation has been included in #57. Please feel free to review.

Amazing, this is extra awesome! Thanks!!

It is our pleasure, Wey.

Currently we are working on a project which using flink SQL to process data like Kafka -> join nebula -> write nebula. We would like to contribute more codes to community in the future. Hence any comments are appreciated:)

@wey-gu
Copy link
Author

wey-gu commented Jun 17, 2022

Thank you so much @spike-liu !

It's so lucky to have you in the community, and if you don't mind, it's more than welcome to share your work in our meetup/blog, too :)

cc @tian-zhong @lisahui @Nicole00

@spike-liu
Copy link
Contributor

Thank you so much @spike-liu !

It's so lucky to have you in the community, and if you don't mind, it's more than welcome to share your work in our meetup/blog, too :)

cc @tian-zhong @lisahui @Nicole00

Definitely, best practice would also be scheduled in community.

@liuxiaocs7
Copy link
Contributor

I noticed that Flink has updated the source and sink function interfaces, just as FLIP-27: Refactor Source Interface and FLIP-143: Unified Sink API, should we update the interfaces if we want to support more higher version of flink.

@Nicole00
Copy link
Contributor

Nicole00 commented Jul 9, 2022

I noticed that Flink has updated the source and sink function interfaces, just as FLIP-27: Refactor Source Interface and FLIP-143: Unified Sink API, should we update the interfaces if we want to support more higher version of flink.

Great idea! @spike-liu could you take up your precious time to discuss this idea together if you are interested in it? We'll be very glad to hear from you and your team.

@spike-liu
Copy link
Contributor

I noticed that Flink has updated the source and sink function interfaces, just as FLIP-27: Refactor Source Interface and FLIP-143: Unified Sink API, should we update the interfaces if we want to support more higher version of flink.

Great idea! @spike-liu could you take up your precious time to discuss this idea together if you are interested in it? We'll be very glad to hear from you and your team.

This is our honor, @Nicole00.

There are a lot of information in these two proposals. Please give us some time to read them.

@liuxiaocs7 Thanks for bring it on.

@spike-liu
Copy link
Contributor

spike-liu commented Jul 12, 2022

created separate issues to discuss.

@spike-liu
Copy link
Contributor

@wey-gu this issue could be closed and completed in 93df7a1

@wey-gu
Copy link
Author

wey-gu commented Jul 13, 2022

Roger that :) Thanks a lot, @spike-liu !

Thanks a lot for @liuxiaocs7 and @JimWen , too!

@wey-gu wey-gu closed this as completed Jul 13, 2022
@spike-liu
Copy link
Contributor

Roger that :) Thanks a lot, @spike-liu !

Thanks a lot for @liuxiaocs7 and @JimWen , too!

My pleasure, Wey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants