Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to support FLIP-27: Refactor Source Interface #65

Closed
spike-liu opened this issue Jul 13, 2022 · 5 comments
Closed

Do we need to support FLIP-27: Refactor Source Interface #65

spike-liu opened this issue Jul 13, 2022 · 5 comments

Comments

@spike-liu
Copy link
Contributor

Split discussion from #38

@spike-liu spike-liu changed the title Do we need to support FLIP-143: Unified Sink API? Do we need to support FLIP-27: Refactor Source Interface Jul 15, 2022
@spike-liu
Copy link
Contributor Author

@spike-liu
Copy link
Contributor Author

spike-liu commented Jul 15, 2022

Here is my research:

  1. The problems mentioned below currently are not problem for nebula connector.

image

  1. Currently only message queue framework, such as Kafka/Pulsar, implemented this new API.

image

So far, from my point of view, there is no motivation for us to implement these new source API.

@Nicole00 what is your idea?

@Nicole00
Copy link
Contributor

Sorry I missed this issue, I'll research it and reply later.

@Nicole00
Copy link
Contributor

I agree with @spike-liu .
The main motivation of flip-27 is to facilitate the expansion of data sources and lower the threshold for everyone to contribute source code. Sense we have extended the Nebula data source, it seems there's no need to refactor the interface.

And the use requirement of checkpoint is not high, so I tend to see the support of FILP-27 as a future requirement.

@spike-liu
Copy link
Contributor Author

Thanks for your reply. @Nicole00

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants