Create integration tests #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, @peczenyj for your elegant work. Now, the ability to run pure UT w/ Functional/Integration ones relying on the heavier docker-compose is so very important and awesome. |
wey-gu
approved these changes
May 5, 2022
peczenyj
added a commit
to peczenyj/nebula-go
that referenced
this pull request
May 8, 2022
* add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results
peczenyj
added a commit
to peczenyj/nebula-go
that referenced
this pull request
May 8, 2022
* add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results
Aiee
added a commit
that referenced
this pull request
May 10, 2022
… as a nebula driver (#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <[email protected]>
peczenyj
added a commit
to peczenyj/nebula-go
that referenced
this pull request
May 10, 2022
… as a nebula driver (vesoft-inc#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (vesoft-inc#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <[email protected]>
Aiee
added a commit
that referenced
this pull request
Jul 1, 2022
* update test to check ipv6 version of localhost * use net.JoinHostPort to handle the ipv6 case properly * remove remote services, the code is not necessary to use this project as a nebula driver (#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: Yichen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I note that most of the tests are integration tests instead unit tests. They need a nebula db running and listening to be executed.
This indeed is a very precise way to stablish that one driver is running fine: if we can interact with a real database with success it means the driver is correct. However it demands a specific environment and it may trigger false negatives (in case of timeouts, etc). A better approach is to having a way to easily run all unit tests - to be used as a quick check, before run a full integration test suite.
By using build tags, we can run unit and integration tests easily.
I add a
make unitfor thisRegards