Add 3.3.1 release #238
Merged
Add 3.3.1 release #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add codecov * add codecov badge
Close deprecated connections from idle queue to avoid leaks.
* Update thrift files to v3.3 core * Comment out test * Fix typo
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-3.3 #238 +/- ##
==============================================
Coverage ? 62.64%
==============================================
Files ? 9
Lines ? 2230
Branches ? 0
==============================================
Hits ? 1397
Misses ? 693
Partials ? 140 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I am confused that we updated thrift generated files when meta or storage's thrift file changed but never use them in this client repo, does this update make any sense? |
|
@Aiee any answer for upper question is appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.